JavaScript Challenge Feature for Application Gateway Firewall Policy Settings #24425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.ApplicationInsights
️✔️Az.Batch
️✔️Az.CognitiveServices
️✔️Az.Compute
️✔️Az.ContainerRegistry
️✔️Az.CosmosDB
️✔️Az.DataLakeStore
️✔️Az.Dns
️✔️Az.EventHub
|
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 22.09 % | Test coverage for the module cannot be lower than 50%. |
⚠️ - MacOS
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 22.09% | Test coverage for the module cannot be lower than 50%. |
⚠️ PowerShell Core - Windows
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 22.09% | Test coverage for the module cannot be lower than 50%. |
⚠️ Windows PowerShell - Windows
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 22.09% | Test coverage for the module cannot be lower than 50%. |
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 18.18 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 18.18% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 18.18% Test coverage for the module cannot be lower than 50%.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 18.18% Test coverage for the module cannot be lower than 50%.
️✔️Az.NetAppFiles
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Help Example Check
⚠️ PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ New-AzApplicationGatewayFirewallPolicySetting 1 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -State $enabledState is a null-valued parameter value. -State Assign value for $enabledState. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 1 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -Mode $enabledMode is a null-valued parameter value. -Mode Assign value for $enabledMode. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 1 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -MaxFileUploadInMb $fileUploadLimitInMb is a null-valued parameter value. -MaxFileUploadInMb Assign value for $fileUploadLimitInMb. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 1 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -MaxRequestBodySizeInKb $maxRequestBodySizeInKb is a null-valued parameter value. -MaxRequestBodySizeInKb Assign value for $maxRequestBodySizeInKb. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 2 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -State $enabledState is a null-valued parameter value. -State Assign value for $enabledState. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 2 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -Mode $enabledMode is a null-valued parameter value. -Mode Assign value for $enabledMode. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 2 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -MaxFileUploadInMb $fileUploadLimitInMb is a null-valued parameter value. -MaxFileUploadInMb Assign value for $fileUploadLimitInMb. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 2 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -MaxRequestBodySizeInKb $maxRequestBodySizeInKb is a null-valued parameter value. -MaxRequestBodySizeInKb Assign value for $maxRequestBodySizeInKb. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 2 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -LogScrubbing $logScrubbingRuleConfig is a null-valued parameter value. -LogScrubbing Assign value for $logScrubbingRuleConfig. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 3 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -State $enabledState is a null-valued parameter value. -State Assign value for $enabledState. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 3 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -Mode $enabledMode is a null-valued parameter value. -Mode Assign value for $enabledMode. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 3 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -MaxFileUploadInMb $fileUploadLimitInMb is a null-valued parameter value. -MaxFileUploadInMb Assign value for $fileUploadLimitInMb. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 3 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -MaxRequestBodySizeInKb $maxRequestBodySizeInKb is a null-valued parameter value. -MaxRequestBodySizeInKb Assign value for $maxRequestBodySizeInKb. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 4 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -State $enabledState is a null-valued parameter value. -State Assign value for $enabledState. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 4 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -Mode $enabledMode is a null-valued parameter value. -Mode Assign value for $enabledMode. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 4 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -MaxFileUploadInMb $fileUploadLimitInMb is a null-valued parameter value. -MaxFileUploadInMb Assign value for $fileUploadLimitInMb. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 4 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -MaxRequestBodySizeInKb $maxRequestBodySizeInKb is a null-valued parameter value. -MaxRequestBodySizeInKb Assign value for $maxRequestBodySizeInKb. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 4 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -JSChallengeCookieExpirationInMins $jsChallengeCookieExpirationInMins is a null-valued parameter value. -JSChallengeCookieExpirationInMins Assign value for $jsChallengeCookieExpirationInMins.
⚠️ Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ New-AzApplicationGatewayFirewallPolicySetting 1 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -State $enabledState is a null-valued parameter value. -State Assign value for $enabledState. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 1 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -Mode $enabledMode is a null-valued parameter value. -Mode Assign value for $enabledMode. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 1 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -MaxFileUploadInMb $fileUploadLimitInMb is a null-valued parameter value. -MaxFileUploadInMb Assign value for $fileUploadLimitInMb. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 1 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -MaxRequestBodySizeInKb $maxRequestBodySizeInKb is a null-valued parameter value. -MaxRequestBodySizeInKb Assign value for $maxRequestBodySizeInKb. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 2 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -State $enabledState is a null-valued parameter value. -State Assign value for $enabledState. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 2 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -Mode $enabledMode is a null-valued parameter value. -Mode Assign value for $enabledMode. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 2 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -MaxFileUploadInMb $fileUploadLimitInMb is a null-valued parameter value. -MaxFileUploadInMb Assign value for $fileUploadLimitInMb. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 2 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -MaxRequestBodySizeInKb $maxRequestBodySizeInKb is a null-valued parameter value. -MaxRequestBodySizeInKb Assign value for $maxRequestBodySizeInKb. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 2 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -LogScrubbing $logScrubbingRuleConfig is a null-valued parameter value. -LogScrubbing Assign value for $logScrubbingRuleConfig. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 3 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -State $enabledState is a null-valued parameter value. -State Assign value for $enabledState. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 3 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -Mode $enabledMode is a null-valued parameter value. -Mode Assign value for $enabledMode. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 3 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -MaxFileUploadInMb $fileUploadLimitInMb is a null-valued parameter value. -MaxFileUploadInMb Assign value for $fileUploadLimitInMb. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 3 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -MaxRequestBodySizeInKb $maxRequestBodySizeInKb is a null-valued parameter value. -MaxRequestBodySizeInKb Assign value for $maxRequestBodySizeInKb. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 4 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -State $enabledState is a null-valued parameter value. -State Assign value for $enabledState. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 4 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -Mode $enabledMode is a null-valued parameter value. -Mode Assign value for $enabledMode. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 4 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -MaxFileUploadInMb $fileUploadLimitInMb is a null-valued parameter value. -MaxFileUploadInMb Assign value for $fileUploadLimitInMb. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 4 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -MaxRequestBodySizeInKb $maxRequestBodySizeInKb is a null-valued parameter value. -MaxRequestBodySizeInKb Assign value for $maxRequestBodySizeInKb. ⚠️ New-AzApplicationGatewayFirewallPolicySetting 4 1 Unassigned_Variable New-AzApplicationGatewayFirewallPolicySetting -JSChallengeCookieExpirationInMins $jsChallengeCookieExpirationInMins is a null-valued parameter value. -JSChallengeCookieExpirationInMins Assign value for $jsChallengeCookieExpirationInMins. ️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 78.58 % 84.35% Test coverage cannot be lower than the number of the last release.
⚠️ - MacOS
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 78.58% 84.35% Test coverage cannot be lower than the number of the last release.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 78.58% 84.35% Test coverage cannot be lower than the number of the last release.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 78.58% 84.35% Test coverage cannot be lower than the number of the last release.
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Security
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ServiceBus
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.SignalR
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Websites
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
Shawnli222
changed the title
Shawnli222
changed the title
Shawnli222
changed the title
ssevugan21
reviewed
Apr 22, 2024
...etwork/Network/FirewallPolicy/PolicySettings/AzureApplicationGatewayFirewallPolicySetting.cs
Show resolved
Hide resolved
tejasshah7
reviewed
Apr 23, 2024
...etwork/Network/FirewallPolicy/PolicySettings/AzureApplicationGatewayFirewallPolicySetting.cs
Show resolved
Hide resolved
tejasshah7
approved these changes
Apr 23, 2024
YanaXu
reviewed
Apr 24, 2024
| @@ -446,3 +446,4 @@ | |||
| "Az.Network","Microsoft.Azure.Commands.Network.UpdateAzureRmP2SVpnGatewayCommand","Update-AzP2sVpnGateway","1","8700","Parameter set 'ByP2SVpnGatewayResourceIdNoVpnServerConfigurationUpdate', 'ByP2SVpnGatewayResourceIdByVpnServerConfigurationObject' of cmdlet 'Update-AzP2sVpnGateway' have the same mandatory parameters, and both of them are not default parameter set which may cause confusion.","Merge these parameter sets into one parameter set." | |||
| "Az.Network","Microsoft.Azure.Commands.Network.Bastion.NewAzBastionCommand","New-AzBastion","1","8410","Parameter EnableKerberos of cmdlet New-AzBastion does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name." | |||
| "Az.Network","Microsoft.Azure.Commands.Network.Bastion.SetAzBastionCommand","Set-AzBastion","1","8410","Parameter EnableKerberos of cmdlet Set-AzBastion does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name." | |||
| "Az.Network","Microsoft.Azure.Commands.Network.NewAzureApplicationGatewayFirewallPolicySettingCommand","New-AzApplicationGatewayFirewallPolicySetting","1","8410","Parameter JSChallengeCookieExpirationInMins of cmdlet New-AzApplicationGatewayFirewallPolicySetting does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name." | |||
There was a problem hiding this comment.
@Shawnli222, can you rename the parameter using a singular noun instead of suppressing the issue?
There was a problem hiding this comment.
We have to make it the same as the swagger PR so it had to be like this
There was a problem hiding this comment.
Here is the swagger link: Azure/azure-rest-api-specs#28011
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
YanaXu
approved these changes
Apr 25, 2024
YanaXu
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow customers to add expiration time for JSChallenge Cookie for application gateway firewall policy settings. This feature is built on the existing Firewall PolicySettings framework. A new field JsChallengeCookieExpirationInMins is added to provide JavaScript Challenge Feature.
Swagger PR link: Azure/azure-rest-api-specs#28011
Mandatory Checklist
Please choose the target release of Azure PowerShell
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.